Describe your changes:

No issue linked — dead code cleanup.

I removed the unused 3-arg McpUsageRecorder.record(String, String, boolean) overload and its dedicated legacy3ArgOverloadOmitsPhase3Fields test, because the only production caller (McpServer) uses the 6-arg form.

The 3-arg overload was the original signature; the single production call site was migrated to the 6-arg overload in the same commit that introduced the 6-arg form, leaving the 3-arg as a delegating shim whose "kept so existing call sites compile unchanged" comment was stale — no production call sites remained. Its only callers were in McpUsageRecorderTest.

The 5 remaining tests that exercised general recording behavior via the shim now call the 6-arg overload with null, null, null (exactly what the removed overload delegated to), so behavior under test is unchanged. The 6-arg record method, its private resolveMcpApp/getDao helpers, and all logging are left intact (live code with a production caller).

Type of change:

• Improvement

High-level design:

N/A — small change.

Tests:

Use cases covered

• MCP usage recording still builds and the recorder's existing unit tests pass after removing the unused overload.

Unit tests

• Updated McpUsageRecorderTest callers to use the 6-arg overload; removed the now-dead legacy3ArgOverloadOmitsPhase3Fields test.
• mvn test -pl openmetadata-mcp -Dtest=McpUsageRecorderTest passes (6 tests, 0 failures).

Backend integration tests

• Not applicable (no backend API changes).

Ingestion integration tests

• Not applicable (no ingestion changes).

Playwright (UI) tests

• Not applicable (no UI changes).

UI screen recording / screenshots:

Not applicable.

Checklist:

• I have read the CONTRIBUTING document.
• My PR title is Fixes <issue-number>: <short explanation>
• My PR is linked to a GitHub issue via Fixes #<issue-number> above.
• I have commented on my code, particularly in hard-to-understand areas.
• For JSON Schema changes: I updated the migration scripts or explained why it is not needed.
• For UI changes: I attached a screen recording and/or screenshots above.
• I have added tests (unit / integration / Playwright as applicable) and listed them above.

History

• Last materially changed May 2026 (MCP Tool Usage #28352 @harshach)

Dead Code PRs can be configured here.